Review Request 123129: Centralize the cmake code for generating services and providers

Aleix Pol Gonzalez aleixpol at kde.org
Wed Apr 1 16:44:36 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123129/
-----------------------------------------------------------

(Updated April 1, 2015, 4:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Telepathy.


Changes
-------

Submitted with commit 44bb1a9e46432099c4fc1d184a1ce350279b0e27 by Aleix Pol to branch master.


Repository: kaccounts-integration


Description
-------

I wanted to fix the code to generate it at build time rather than configure time, I saw the code was copypasted both in kaccounts-providers and ktp-accounts-kcm.

If we get this in, I can look into doing the generation properly.


Diffs
-----

  src/lib/CMakeLists.txt ddd79b7 
  src/lib/KAccountsConfig.cmake.in ffc6cb5 
  src/lib/KAccountsMacros.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123129/diff/


Testing
-------

Changed it in both places, still works.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150401/7447c1b1/attachment-0001.html>


More information about the KDE-Telepathy mailing list