Review Request 123207: Use connectionStatus to show if we're changing presence

David Edmundson david at davidedmundson.co.uk
Wed Apr 1 12:55:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123207/
-----------------------------------------------------------

(Updated April 1, 2015, 12:55 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Changes
-------

Submitted with commit 40e4e57be8dcfd52db619870a4dc2da7d837ecb8 by David Edmundson to branch Applications/15.04.


Repository: ktp-common-internals


Description
-------

This uses the same metric to show the spinner in the contact list and
the plasmoid.

It stops it spinning eternally and saves plasma-shell's CPU rendering a
spinning thing forever.

This patch is a minimal change that I want to put into 15.04 that
doesn't  alter API.

Afterwards I'll make connectionStatus a property and tidy things up for
master.


Diffs
-----

  KTp/global-presence.h d1f5dab 
  KTp/global-presence.cpp 9c72d40 

Diff: https://git.reviewboard.kde.org/r/123207/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150401/87fac0f0/attachment.html>


More information about the KDE-Telepathy mailing list