Review Request 120301: DBus interface for the kded module and status message plugins

[James Smith]

> On Sept. 21, 2014, 12:32 p.m., David Edmundson wrote:
> > telepathy-module.h, line 85
> > <https://git.reviewboard.kde.org/r/120301/diff/1/?file=314100#file314100line85>
> >
> >     Can you explain this please.

It may be required in applications that set the presence at the same time as disabling the now playing plugin, because the global presence frequently doesn't respond fast enough to make the next presence the selected presence, in addition to deactivating the now playing plugin, which causes a presence change. This isn't needed to simply toggle the now playing plugin, as the global presence ends at what the user expected, ie. the last set presence.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120301/#review67127
-----------------------------------------------------------


On Sept. 21, 2014, 9:53 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120301/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2014, 9:53 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Adds a DBus adaptor class and a number of methods / properties / signals to control and interact with the status handler from DBus.
> 
> 
> Diffs
> -----
> 
>   telepathy-module.h 17ef4cef27b90cbced6c66846ed82cb5c36fb532 
>   telepathy-module.cpp 3c34b6e5e0364334c962b4df0dffc70cffed91bc 
>   CMakeLists.txt a5317b480f2013a1c227c1c7f2da85cad13a64b3 
>   org.kde.Telepathy.StatusMessagePluginInterface.xml PRE-CREATION 
>   org.kde.Telepathy.xml PRE-CREATION 
>   status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff 
>   status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc 
>   telepathy-module-message-plugin-dbus-interface.h PRE-CREATION 
>   telepathy-module-message-plugin-dbus-interface.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120301/diff/
> 
> 
> Testing
> -------
> 
> Compile, quick runtime check.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140926/3b29bb79/attachment.html>