Review Request 120296: Split plugin class for status plugins. Also cleans up the presence plugin class and ports to isConfigEnabled().

[James Smith]

> On Sept. 21, 2014, 1:26 p.m., David Edmundson wrote:
> > telepathy-kded-module-plugin.h, line 72
> > <https://git.reviewboard.kde.org/r/120296/diff/1/?file=314025#file314025line72>
> >
> >     I need this explaining:
> >     
> >     configEnabled
> >     enabled
> >     active
> >     
> >     What's the differenve between each of these.
> 
> James Smith wrote:
>     configEnabled - enabled in config
>     enabled - enabled at runtime. useful for enabling and disabling queues of plugins
>     active - has any output
> 
> David Edmundson wrote:
>     Am I right in thinking it's purely for that now playing situation where we have:
>     
>     the config setting
>     whether the user selected now playing in the contact list
>     whether a song is currently playing
>     
>     
>     For auto away/screensaver this isn't going to be used?

Yes. The other plugins don't benefit, though it'd be nice to disable the presence plugins from the terminal. There's no application that needs direct input into these plugins yet, they both deactivate on activity.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120296/#review67135
-----------------------------------------------------------


On Sept. 21, 2014, 9:53 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120296/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2014, 9:53 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> This was split from #116940, and is a little more conservative. This patch doesn't remove globalPresence from the status message handler class and also doesn't make too many huge changes to the status handler. This patch does include a new virtual config method and moves other functions public to assist in enabling/disabling plugins from the status handler, and is forward-looking in preparation for the status handler to be able to directly control the status message plugins individually.
> 
> 
> Diffs
> -----
> 
>   telepathy-kded-module-plugin.cpp daf73c66947bc946097de7a8e8a1518555131145 
>   telepathy-kded-module-plugin.h 4c161696a706e82059a7eb314773c3644fe26bd7 
>   telepathy-kded-module-message-plugin.cpp PRE-CREATION 
>   status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc 
>   status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff 
>   screensaveraway.cpp e01e067a3f7fa1f05d02eb01a850d3a8b5a0ce93 
>   telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
>   telepathy-mpris.cpp 44b041fdd3764ee5f67598fcf555a2759d853bdd 
>   CMakeLists.txt a5317b480f2013a1c227c1c7f2da85cad13a64b3 
>   telepathy-kded-module-message-plugin.h PRE-CREATION 
>   autoaway.cpp 13b71a53629af6d7141233c5560e1a12c1314e7d 
> 
> Diff: https://git.reviewboard.kde.org/r/120296/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140926/81544a67/attachment.html>