Review Request 120301: DBus interface for the kded module and status message plugins

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120301/#review67127
-----------------------------------------------------------


Can you talk us through this.

My main comment before was that instead of explaining what was wrong with the old system we're just adding more and more code.
This is quite a bit more.


telepathy-module.h
<https://git.reviewboard.kde.org/r/120301/#comment46846>

    Can you explain this please.


- David Edmundson


On Sept. 21, 2014, 9:53 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120301/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2014, 9:53 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Adds a DBus adaptor class and a number of methods / properties / signals to control and interact with the status handler from DBus.
> 
> 
> Diffs
> -----
> 
>   telepathy-module.h 17ef4cef27b90cbced6c66846ed82cb5c36fb532 
>   telepathy-module.cpp 3c34b6e5e0364334c962b4df0dffc70cffed91bc 
>   CMakeLists.txt a5317b480f2013a1c227c1c7f2da85cad13a64b3 
>   org.kde.Telepathy.StatusMessagePluginInterface.xml PRE-CREATION 
>   org.kde.Telepathy.xml PRE-CREATION 
>   status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff 
>   status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc 
>   telepathy-module-message-plugin-dbus-interface.h PRE-CREATION 
>   telepathy-module-message-plugin-dbus-interface.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120301/diff/
> 
> 
> Testing
> -------
> 
> Compile, quick runtime check.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140921/2f81c92b/attachment-0001.html>