Review Request 120098: Only show local video if the call has video content.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120098/#review66035
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Sept. 8, 2014, 5:47 a.m., Diane Trout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120098/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 5:47 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> disable local show local video in calls without video content.
> 
> the empty box with no video was kind of ugly, this is a reasonable solution to remove it. Though I suppose you could argue that a person might turn on local video even in an audio call if they wanted to look at themselves.
> 
> 
> Diffs
> -----
> 
>   src/call-window.cpp a5533a1ae44dfcde96fee635b9bdbf1d06727437 
> 
> Diff: https://git.reviewboard.kde.org/r/120098/diff/
> 
> 
> Testing
> -------
> 
> Compiled.
> 
> Made an audio only call from my phone with jitsi, didn't have a show local video box.
> 
> Made a video call from one account to another and did have a local video box. (Though not very functional due to the issues of having only one camera in a two way call)
> 
> 
> Thanks,
> 
> Diane Trout
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140908/443a3522/attachment.html>