Review Request 120215: Add KAccounts plugin based on Accounts KCM's internal lib

Aleix Pol Gonzalez aleixpol at kde.org
Wed Oct 29 16:17:40 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120215/#review69467
-----------------------------------------------------------


Looks fine to me, but I'm quite clueless about how all that works.

- Aleix Pol Gonzalez


On Oct. 14, 2014, 2:31 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120215/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 2:31 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-accounts-kcm
> 
> 
> Description
> -------
> 
> This is invoked from KAccounts when new KTp account is being created. Basically this is the wizard we have now starting from step two. It takes care about creating the Telepathy account and passing back the password to KAccounts to store it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3543406 
>   cmake/modules/FindKAccounts.cmake PRE-CREATION 
>   plugins/CMakeLists.txt 4a24516 
>   plugins/kaccounts/CMakeLists.txt PRE-CREATION 
>   plugins/kaccounts/kaccounts-ui-provider.h PRE-CREATION 
>   plugins/kaccounts/kaccounts-ui-provider.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120215/diff/
> 
> 
> Testing
> -------
> 
> Successfully created an account from within KAccounts using this plugin.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141029/ec928bb3/attachment.html>


More information about the KDE-Telepathy mailing list