Review Request 119955: Port auth handler SASL operation from KWallet to Accounts SSO

[Martin Klapetek]

> On Oct. 25, 2014, 3:42 p.m., David Edmundson wrote:
> > x-telepathy-password-auth-operation.cpp, line 159
> > <https://git.reviewboard.kde.org/r/119955/diff/3/?file=317521#file317521line159>
> >
> >     there's a code path where we don't delete m_dialog.
> >     
> >     Maybe we can just move it to the end? outside all the if else

We can't, there's a lambda inside using it and deleting it after the if would mean that the dialog will be null in the lambda. Missing delete added however.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119955/#review69139
-----------------------------------------------------------


On Oct. 9, 2014, 11:20 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119955/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 11:20 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-auth-handler
> 
> 
> Description
> -------
> 
> This makes auth handler look into the SSO storage for credentials. If the password is wrong, the user is prompted for new one and if he wants to save that password, the password is overriden in SSO.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5994416 
>   cmake/modules/FindKAccounts.cmake PRE-CREATION 
>   getcredentialsjob.h 0981115 
>   getcredentialsjob.cpp 7016ede 
>   sasl-auth-op.h 9808019 
>   sasl-auth-op.cpp c54d662 
>   x-telepathy-password-auth-operation.h 65d6462 
>   x-telepathy-password-auth-operation.cpp f999748 
>   x-telepathy-password-prompt.h fa8c1ce 
>   x-telepathy-password-prompt.cpp b53b1f5 
>   x-telepathy-sso-facebook-operation.h 921ef2a 
>   x-telepathy-sso-facebook-operation.cpp a4a9dc9 
>   x-telepathy-sso-google-operation.h 1fa4c3d 
>   x-telepathy-sso-google-operation.cpp f678916 
> 
> Diff: https://git.reviewboard.kde.org/r/119955/diff/
> 
> 
> Testing
> -------
> 
> I created an account using KAccounts with both good and wrong password. With good password it just authenticates as expected, with wrong password I get a password prompt, entering a correct password makes it override the stored one and any further login does not spawn the password prompt again.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141029/768bced3/attachment.html>