Review Request 120861: Port away from some kdelibs4support
Martin Klapetek
martin.klapetek at gmail.com
Tue Oct 28 19:34:56 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120861/#review69335
-----------------------------------------------------------
Ship it!
abstract-contact-delegate.cpp
<https://git.reviewboard.kde.org/r/120861/#comment48474>
#include <QFontDatabase>
dialogs/remove-contact-dialog.cpp
<https://git.reviewboard.kde.org/r/120861/#comment48475>
The comment should be changed too ;)
- Martin Klapetek
On Oct. 28, 2014, 6:52 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120861/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 6:52 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-contact-list
>
>
> Description
> -------
>
> Should be quite straightforward, but it's better if somebody else can look.
>
>
> Diffs
> -----
>
> contact-overlays.cpp ee14e8f
> context-menu.cpp 586d645
> dialogs/remove-contact-dialog.cpp 78c8197
> filter-bar.cpp 6ae98df
> global-presence-chooser.cpp 1605486
> main-widget.h 227757e
> main-widget.cpp 7e9614f
> tooltips/contacttooltip.cpp b738e3d
> tooltips/ktooltip.cpp 246b703
> tooltips/persontooltip.cpp f086c8b
> tooltips/tooltipmanager.cpp 555d425
> abstract-contact-delegate.cpp 64b0b4f
> account-button.cpp 6b87a73
> contact-delegate-compact.cpp d70853a
> contact-delegate.cpp e7de812
> contact-list-widget.cpp b659ae5
>
> Diff: https://git.reviewboard.kde.org/r/120861/diff/
>
>
> Testing
> -------
>
> Not much, everything still builds, can run the components I've tried.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141028/3ebb24c9/attachment.html>
More information about the KDE-Telepathy
mailing list