Review Request 120864: [ktp-kded-module] Convert to QLoggingCategory

[Aleix Pol Gonzalez]

> On Oct. 28, 2014, 6:19 p.m., Aleix Pol Gonzalez wrote:
> > autoconnect.h, line 89
> > <https://git.reviewboard.kde.org/r/120864/diff/1/?file=322644#file322644line89>
> >
> >     qCWarning?
> 
> Hrvoje Senjan wrote:
>     it is in a header,so i'm not sure how to do it..

I would suggest to move it into a cpp file, but for now leave it as qWarning().

Also this could be turn into a switch() and remove quite some stringtomode calls... we can do it another day xD.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120864/#review69322
-----------------------------------------------------------


On Oct. 28, 2014, 6:18 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120864/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 6:18 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> so it doesn't spam kded5 output ;-)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt fef3f0d009f2550491c45747fb62b442ff455d6e 
>   autoaway.cpp 825073175b55d51ec790b271a63c42b41f566f3e 
>   autoconnect.h 9af58e78f6e92bcb8fe9a1894e1a47e715033f9b 
>   contact-cache.cpp 2c2124c1c16875739afb31c365cab3c9375dc6a4 
>   contact-request-handler.cpp 2d3239e20f80987741c65545e9d6636ced5baf10 
>   contactnotify.cpp fdd25b052fc957f7401c83e3df8a103a2fe35c1c 
>   error-handler.cpp cb0fbb66b49a7075432b069601a720dd9d927a76 
>   ktp_kded_debug.h PRE-CREATION 
>   ktp_kded_debug.cpp PRE-CREATION 
>   screensaveraway.cpp b6a0268a8229e674507c76582f4fa7a9446fbc00 
>   telepathy-module.cpp 3c34b6e5e0364334c962b4df0dffc70cffed91bc 
>   telepathy-mpris.cpp 44b041fdd3764ee5f67598fcf555a2759d853bdd 
> 
> Diff: https://git.reviewboard.kde.org/r/120864/diff/
> 
> 
> Testing
> -------
> 
> builds
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141028/ef283a9e/attachment.html>