Review Request 120521: Finish the KAccounts plugin that handles creating/removing and enabling/disabling Telepathy accounts from inside KAccounts

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120521/#review69288
-----------------------------------------------------------



kaccounts/kaccounts-ktp-plugin.cpp
<https://git.reviewboard.kde.org/r/120521/#comment48437>

    Either const& or no const?



kaccounts/kaccounts-ktp-plugin.cpp
<https://git.reviewboard.kde.org/r/120521/#comment48439>

    if (1)? 
    
    =.=
    
    Unrelated anyway...



kaccounts/kaccounts-ktp-plugin.cpp
<https://git.reviewboard.kde.org/r/120521/#comment48438>

    "this" is not needed.



kaccounts/kaccounts-ktp-plugin.cpp
<https://git.reviewboard.kde.org/r/120521/#comment48436>

    You don't need to pass "this" to the lambda, it just uses op, as far as I see.


Anyway, these are quite small details anyway, looks like it should go in sooner than later.

- Aleix Pol Gonzalez


On Oct. 7, 2014, 2:49 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120521/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2014, 2:49 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> This finishes the KAccounts plugin for KTp. Telepathy accounts are now created/removed for all KAccounts accounts which provide the IM service (till now it was only direct KTp accounts). Furthermore this makes enabling/disabling accounts from KAccounts work too.
> 
> 
> Diffs
> -----
> 
>   kaccounts/CMakeLists.txt 7305d81 
>   kaccounts/kaccounts-ktp-plugin.h 92cbc18 
>   kaccounts/kaccounts-ktp-plugin.cpp f9b722c 
> 
> Diff: https://git.reviewboard.kde.org/r/120521/diff/
> 
> 
> Testing
> -------
> 
> Created couple accounts, enabled and disabled them, removed them again in the end and cross-checked each operation with contact list & mc-tool. All is good.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141028/165349cc/attachment.html>