Review Request 120795: [ktp-auth-handler] Make it build

[Hrvoje Senjan]

> On Oct. 27, 2014, 1:39 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 67
> > <https://git.reviewboard.kde.org/r/120795/diff/1/?file=322019#file322019line67>
> >
> >     It's odd that qca exported target doesn't have a namespace... Are you sure you have the last QCA?

yep...
set_target_properties(${QCA_LIB_NAME} PROPERTIES
                      VERSION ${QCA_LIB_MAJOR_VERSION}.${QCA_LIB_MINOR_VERSION}.${QCA_LIB_PATCH_VERSION}
                      SOVERSION ${QCA_LIB_MAJOR_VERSION}
                      DEFINE_SYMBOL QCA_MAKEDLL
                      PUBLIC_HEADER "${public_HEADERS}"
                      EXPORT_NAME qca
                      )


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120795/#review69180
-----------------------------------------------------------


On Oct. 25, 2014, 7:21 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120795/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2014, 7:21 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-auth-handler
> 
> 
> Description
> -------
> 
> plus other misc. things.. can split the patches up, as not everything's related
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5994416 
>   cmake/modules/FindKTp.cmake 8facd12 
>   cmake/modules/FindQJSON.cmake 4781c0a 
>   main.cpp 19f4b07 
>   org.freedesktop.Telepathy.Client.KTp.ConfAuthObserver.service.in 928a71d 
>   org.freedesktop.Telepathy.Client.KTp.SASLHandler.service.in b29d7e1 
>   org.freedesktop.Telepathy.Client.KTp.TLSHandler.service.in e8d6f0f 
> 
> Diff: https://git.reviewboard.kde.org/r/120795/diff/
> 
> 
> Testing
> -------
> 
> builds against latest frameworks ktp-c-i
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141027/a733be91/attachment.html>