Review Request 120804: Initial port to KF5

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120804/#review69182
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/120804/#comment48351>

    I don't think you need cmake/modules anymore.



src/handle-incoming-file-transfer-channel-job.cpp
<https://git.reviewboard.kde.org/r/120804/#comment48352>

    Are you sure url.path() will keep the trailing slash?



src/handle-incoming-file-transfer-channel-job.cpp
<https://git.reviewboard.kde.org/r/120804/#comment48353>

    Don't use QDir::separator(), use QLatin1Char('/').



src/telepathy-base-job.cpp
<https://git.reviewboard.kde.org/r/120804/#comment48354>

    That change shouldn't be needed...?


- Aleix Pol Gonzalez


On Oct. 26, 2014, 12:26 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120804/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2014, 12:26 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-filetransfer-handler
> 
> 
> Description
> -------
> 
> Initial port to KF5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5664e52 
>   src/CMakeLists.txt ebd892c 
>   src/handle-incoming-file-transfer-channel-job.cpp 36b8310 
>   src/handle-outgoing-file-transfer-channel-job.cpp 762bd12 
>   src/main.cpp 5382122 
>   src/telepathy-base-job.cpp 3dab71e 
> 
> Diff: https://git.reviewboard.kde.org/r/120804/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141027/a30e2eea/attachment-0001.html>