Review Request 120799: Migrate settings from existing 4.x installations

[Luca Beltrame]

> On Ott. 25, 2014, 6:35 p.m., David Edmundson wrote:
> > Can you check this only runs once?

>From the code:

   Q_FOREACH (const QString &configFileName, d->configFiles) {
        const QString newConfigLocation
            = QStandardPaths::writableLocation(QStandardPaths::ConfigLocation)
              + QLatin1Char('/') + configFileName;

        if (QFile(newConfigLocation).exists()) {
            continue;
        }

So yes, it does nothing if the file already exists.


- Luca


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120799/#review69147
-----------------------------------------------------------


On Ott. 25, 2014, 6:33 p.m., Luca Beltrame wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120799/
> -----------------------------------------------------------
> 
> (Updated Ott. 25, 2014, 6:33 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> This uses the Kdelibs4ConfigMigrator class (from kcoreaddons) to seamlessly copy over the configuration files and ui.rc files from their 4.x counterparts to the KF5 locations. 
> 
> If this is acceptable, I could do some more parts of KTP.
> 
> 
> Diffs
> -----
> 
>   app/main.cpp 217bb1c 
> 
> Diff: https://git.reviewboard.kde.org/r/120799/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Luca Beltrame
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141025/e8591030/attachment.html>