Review Request 120795: [ktp-auth-handler] Make it build
Martin Klapetek
martin.klapetek at gmail.com
Sat Oct 25 10:14:32 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120795/#review69134
-----------------------------------------------------------
CMakeLists.txt
<https://git.reviewboard.kde.org/r/120795/#comment48324>
That doesn't sound right; especially since qca can have random suffixes; this should always use the CMake variable
- Martin Klapetek
On Oct. 25, 2014, 7:21 a.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120795/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2014, 7:21 a.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-auth-handler
>
>
> Description
> -------
>
> plus other misc. things.. can split the patches up, as not everything's related
>
>
> Diffs
> -----
>
> CMakeLists.txt 5994416
> cmake/modules/FindKTp.cmake 8facd12
> cmake/modules/FindQJSON.cmake 4781c0a
> main.cpp 19f4b07
> org.freedesktop.Telepathy.Client.KTp.ConfAuthObserver.service.in 928a71d
> org.freedesktop.Telepathy.Client.KTp.SASLHandler.service.in b29d7e1
> org.freedesktop.Telepathy.Client.KTp.TLSHandler.service.in e8d6f0f
>
> Diff: https://git.reviewboard.kde.org/r/120795/diff/
>
>
> Testing
> -------
>
> builds against latest frameworks ktp-c-i
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141025/4282602c/attachment.html>
More information about the KDE-Telepathy
mailing list