Review Request 120793: Initial port of ktp-approver to Frameworks

[Hrvoje Senjan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120793/
-----------------------------------------------------------

Review request for Telepathy.


Repository: ktp-approver


Description
-------

quick&dirty port. coffee didn't kick in yet, so please double check the patch

from quick glance (and not knowing the code from before; most, if not all KAboutData instances could be just ripped out, seems they where used mostly for KNotification setComponentData?)
also ktpapproverfactory.h can now be git rm'ed


Diffs
-----

  src/textchannelapprover.cpp 67c66ce 
  src/tubechannelapprover.cpp 836ac23 
  CMakeLists.txt 59e65f3 
  src/CMakeLists.txt 60609d8 
  src/filetransferchannelapprover.cpp 43393c0 
  src/handlewithcaller.cpp 15934a0 
  src/ktpapprovermodule.cpp 2ddd33e 
  src/org.freedesktop.Telepathy.Client.KTp.Approver.service.in 02e92e2 

Diff: https://git.reviewboard.kde.org/r/120793/diff/


Testing
-------

builds, i get notifications for new messages...


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141025/b7d9a81b/attachment-0001.html>