Review Request 120588: Handle the case where there is not a valid recentRoomsGroup.

[Diane Trout]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120588/
-----------------------------------------------------------

(Updated Oct. 18, 2014, 4:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Repository: ktp-common-internals


Description
-------

I have some inactive accounts and for some rason the Q_FOREACH was
being executed by the readEntry was returning an invalid recent list.

This handles that case and prevents a crash when accessing off the end
of the list.


Diffs
-----

  KTp/Widgets/join-chat-room-dialog.cpp 94f1d2402ecba519cd049e704ca884f92b718fac 

Diff: https://git.reviewboard.kde.org/r/120588/diff/


Testing
-------

Run ktp with my overly complex configuration.
Click on "Join Group Chat" watch contact list crash.
Apply this patch
Click "Join Group Chat" watch error messages about disabled accounts, and then join a conference room with a currently active account.


Thanks,

Diane Trout

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141018/2fb48f63/attachment.html>