Review Request 120588: Handle the case where there is not a valid recentRoomsGroup.

[Diane Trout]

> On Oct. 15, 2014, 2:11 a.m., Martin Klapetek wrote:
> > KTp/Widgets/join-chat-room-dialog.cpp, line 471
> > <https://git.reviewboard.kde.org/r/120588/diff/1/?file=318557#file318557line471>
> >
> >     Shouldn't this be ">=" ?

It should be either >= 2 or > 1, or possibly == 2. The code being protected accesses 2 elements.


- Diane


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120588/#review68435
-----------------------------------------------------------


On Oct. 14, 2014, 11:56 a.m., Diane Trout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120588/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 11:56 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> I have some inactive accounts and for some rason the Q_FOREACH was
> being executed by the readEntry was returning an invalid recent list.
> 
> This handles that case and prevents a crash when accessing off the end
> of the list.
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/join-chat-room-dialog.cpp 94f1d2402ecba519cd049e704ca884f92b718fac 
> 
> Diff: https://git.reviewboard.kde.org/r/120588/diff/
> 
> 
> Testing
> -------
> 
> Run ktp with my overly complex configuration.
> Click on "Join Group Chat" watch contact list crash.
> Apply this patch
> Click "Join Group Chat" watch error messages about disabled accounts, and then join a conference room with a currently active account.
> 
> 
> Thanks,
> 
> Diane Trout
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141015/65f070e4/attachment.html>