Review Request 120521: Finish the KAccounts plugin that handles creating/removing and enabling/disabling Telepathy accounts from inside KAccounts

[Martin Klapetek]

> On Oct. 9, 2014, 6:35 p.m., Àlex Fiestas wrote:
> > I would like to see this new code tested either by unit tests (preferred) or integration test.
> 
> Àlex Fiestas wrote:
>     Also think that lambdas might make the code look cool but they usually produce coupling are are really hard to test, so be careful.

Unit testing the Telepathy stuff in combination with the SSO stuff and a kded module is something I'm not sure is possible to do sensibly. Suggestions welcome of course.

As for lambdas, well I'm using them because they are convenient, not because they look cool :P (and I don't think they look that cool anyway;)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120521/#review68176
-----------------------------------------------------------


On Oct. 7, 2014, 4:49 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120521/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2014, 4:49 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> This finishes the KAccounts plugin for KTp. Telepathy accounts are now created/removed for all KAccounts accounts which provide the IM service (till now it was only direct KTp accounts). Furthermore this makes enabling/disabling accounts from KAccounts work too.
> 
> 
> Diffs
> -----
> 
>   kaccounts/CMakeLists.txt 7305d81 
>   kaccounts/kaccounts-ktp-plugin.h 92cbc18 
>   kaccounts/kaccounts-ktp-plugin.cpp f9b722c 
> 
> Diff: https://git.reviewboard.kde.org/r/120521/diff/
> 
> 
> Testing
> -------
> 
> Created couple accounts, enabled and disabled them, removed them again in the end and cross-checked each operation with contact list & mc-tool. All is good.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141013/55f0d43c/attachment.html>