Review Request 121232: Ensure we're not calling allKnownContacts too early

David Edmundson david at davidedmundson.co.uk
Tue Nov 25 11:32:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121232/#review70908
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Nov. 24, 2014, 6:53 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121232/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 6:53 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Currently KTP is loading the contact list too early, before the roster is ready and we get many warnings about how it's too early. This drops some of those warnings, although the former should be fixed too.
> 
> If somebody can point me where to look, I'd be very thankful :).
> 
> 
> Diffs
> -----
> 
>   KTp/global-contact-manager.cpp 07e93f6 
> 
> Diff: https://git.reviewboard.kde.org/r/121232/diff/
> 
> 
> Testing
> -------
> 
> I played around with ktp-contactlist.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141125/b0d7595b/attachment.html>


More information about the KDE-Telepathy mailing list