Review Request 121199: Make use of KTp AM singleton in dialogs

Martin Klapetek martin.klapetek at gmail.com
Fri Nov 21 12:09:40 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121199/#review70735
-----------------------------------------------------------

Ship it!


This also needs patches everywhere this is used, otherwise all will fail building.

- Martin Klapetek


On Nov. 21, 2014, 12:20 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121199/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2014, 12:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Makes things consistent and a bit tidier.
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/start-chat-dialog.h cab782a 
>   KTp/Widgets/start-chat-dialog.cpp 58c9987 
>   KTp/Declarative/telepathy-manager.cpp 0eef901 
>   KTp/Widgets/add-contact-dialog.h 6ec0da5 
>   KTp/Widgets/add-contact-dialog.cpp 578fcde 
>   KTp/Widgets/join-chat-room-dialog.h e1d6237 
>   KTp/Widgets/join-chat-room-dialog.cpp c3cf08f 
> 
> Diff: https://git.reviewboard.kde.org/r/121199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141121/7584a17d/attachment.html>


More information about the KDE-Telepathy mailing list