Review Request 121124: Move ContactInfoDialog to KTp/Widgets and port away from kdelibs4support
Martin Klapetek
martin.klapetek at gmail.com
Fri Nov 14 19:14:45 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121124/#review70380
-----------------------------------------------------------
Humm, actually I'll post another RR with diff against the contact-info-dialog still in KTp, so the changes in the file alone can be reviewed. Let this one serve as a RR for the move to Widgets/
- Martin Klapetek
On Nov. 14, 2014, 8:13 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121124/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 8:13 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> Moves ContactInfoDialog to KTp/Widgets (it's a widget after all) and ports away from kdelibs4support
>
>
> Diffs
> -----
>
> KTp/CMakeLists.txt cd94aef
> KTp/Widgets/CMakeLists.txt 64642bb
> KTp/Widgets/contact-info-dialog.h PRE-CREATION
> KTp/Widgets/contact-info-dialog.cpp PRE-CREATION
> KTp/contact-info-dialog.h 833c74f
> KTp/contact-info-dialog.cpp 47206cd
>
> Diff: https://git.reviewboard.kde.org/r/121124/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141114/f880b677/attachment-0001.html>
More information about the KDE-Telepathy
mailing list