Review Request 120509: Fix for status message plugin / presence plugin presences written to disk.

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120509/
-----------------------------------------------------------

(Updated Nov. 12, 2014, 1:13 a.m.)


Review request for Telepathy.


Bugs: 334492
    http://bugs.kde.org/show_bug.cgi?id=334492


Repository: ktp-kded-module


Description (updated)
-------

Make certain the last user presence variable is set from the last saved user presence to prevent the active plugin's presence becoming the user presence when the kded is reinstalled or reloads. This goes along with commit 9b8f17433a7b14b256c1eb9272186c0f00ab416f and reinforces not using automatic presence, and which instead mangles the requested presence at every login or kded reload. requested presence can have been set by the now playing plugin and by subsequent ktp kded module reloads become m_lastUserPresence, which then passes to disk as a user presence, causing the kded to become out of sync with what the user actually set as the last presence, and potentially causing a cascade of unintuitive erronious behaviour.


Diffs
-----

  autoconnect.h 9af58e78f6e92bcb8fe9a1894e1a47e715033f9b 
  autoconnect.cpp dd364930443e0995fcaeb7882a175c234b6a49f6 
  status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc 

Diff: https://git.reviewboard.kde.org/r/120509/diff/


Testing
-------

Compile, run. Start with a fresh lastPresence section in ktelepathyrc.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141112/a54c9abc/attachment-0001.html>