Review Request 119955: Port auth handler SASL operation from KWallet to Accounts SSO

[Aleix Pol Gonzalez]

> On Oct. 29, 2014, 4:15 p.m., Aleix Pol Gonzalez wrote:
> > cmake/modules/FindKAccounts.cmake, line 1
> > <https://git.reviewboard.kde.org/r/119955/diff/3/?file=317515#file317515line1>
> >
> >     Can't we make KAccounts install a KAccountsConfig.cmake file?
> 
> Martin Klapetek wrote:
>     Could be done, but AccountsQt and SignOnQt are still using "the old way"; I'd like to keep KAccoutns more close to that.
> 
> Aleix Pol Gonzalez wrote:
>     Why? In fact you can use KAccountsConfig and targets to figure out the dependencies. I see it as more reason to do so.

FWIW, it doesn't need to block this review request, it can be done sometime else.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119955/#review69464
-----------------------------------------------------------


On Oct. 9, 2014, 9:20 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119955/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 9:20 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-auth-handler
> 
> 
> Description
> -------
> 
> This makes auth handler look into the SSO storage for credentials. If the password is wrong, the user is prompted for new one and if he wants to save that password, the password is overriden in SSO.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5994416 
>   cmake/modules/FindKAccounts.cmake PRE-CREATION 
>   getcredentialsjob.h 0981115 
>   getcredentialsjob.cpp 7016ede 
>   sasl-auth-op.h 9808019 
>   sasl-auth-op.cpp c54d662 
>   x-telepathy-password-auth-operation.h 65d6462 
>   x-telepathy-password-auth-operation.cpp f999748 
>   x-telepathy-password-prompt.h fa8c1ce 
>   x-telepathy-password-prompt.cpp b53b1f5 
>   x-telepathy-sso-facebook-operation.h 921ef2a 
>   x-telepathy-sso-facebook-operation.cpp a4a9dc9 
>   x-telepathy-sso-google-operation.h 1fa4c3d 
>   x-telepathy-sso-google-operation.cpp f678916 
> 
> Diff: https://git.reviewboard.kde.org/r/119955/diff/
> 
> 
> Testing
> -------
> 
> I created an account using KAccounts with both good and wrong password. With good password it just authenticates as expected, with wrong password I get a password prompt, entering a correct password makes it override the stored one and any further login does not spawn the password prompt again.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141111/bfb92395/attachment.html>