Review Request 118358: System tray Icon for KTp-call-UI

[Aleix Pol Gonzalez]

> On May 27, 2014, 11:45 p.m., Aleix Pol Gonzalez wrote:
> > src/call-window.cpp, line 605
> > <https://git.reviewboard.kde.org/r/118358/diff/3/?file=275558#file275558line605>
> >
> >     Why checking if it's hidden? If you received a hideEvent it must be, right?
> 
> Ekaitz Zárraga wrote:
>     Not really, if it's minimized, it makes a hideEvent but it's not hidden. I don't want to show the icon when minimizing the window, if I delete that it appears.

Ok, you can drop the issue.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118358/#review58616
-----------------------------------------------------------


On May 29, 2014, 3:34 p.m., Ekaitz Zárraga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118358/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 3:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> System tray Icon for KTp-call-UI
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 5188f10 
>   src/call-window.h dc742ad 
>   src/call-window.cpp 7e07cfa 
>   src/systemtray-icon.h PRE-CREATION 
>   src/systemtray-icon.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118358/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ekaitz Zárraga
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140529/ac60b725/attachment.html>