Review Request 118358: System tray Icon for KTp-call-UI

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118358/#review58721
-----------------------------------------------------------



src/call-window.cpp
<https://git.reviewboard.kde.org/r/118358/#comment40853>

    I'm not sure we want this in the actionCollection, it means you'd be able to add restore to the toolbar, which doesn't sound very useful.



src/call-window.cpp
<https://git.reviewboard.kde.org/r/118358/#comment40855>

    I don't think we want to accept the events. They need to be propagated upwards



src/call-window.cpp
<https://git.reviewboard.kde.org/r/118358/#comment40856>

    see above



src/systemtray-icon.cpp
<https://git.reviewboard.kde.org/r/118358/#comment40854>

    "The video call window has been hidden, but the call will remain active. Click to restore.@"



src/systemtray-icon.cpp
<https://git.reviewboard.kde.org/r/118358/#comment40858>

    does this mean it will show this message as soon as the window is loaded?



src/systemtray-icon.cpp
<https://git.reviewboard.kde.org/r/118358/#comment40857>

    yesno isn't a great name here.
    We already know it's a bool.
    
    general convention would be "activateNext"
    
    I don't get what this property is for anyway?


- David Edmundson


On May 29, 2014, 11:49 a.m., Ekaitz Zárraga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118358/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 11:49 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> System tray Icon for KTp-call-UI
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 5188f10 
>   src/call-window.h dc742ad 
>   src/call-window.cpp 7e07cfa 
>   src/systemtray-icon.h PRE-CREATION 
>   src/systemtray-icon.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118358/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ekaitz Zárraga
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140529/ce71a386/attachment.html>