Review Request 118256: Implement showMyVideo

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118256/#review58304
-----------------------------------------------------------


Code itself is fine, thanks very much.
Some minor pedantic points.


src/call-window.h
<https://git.reviewboard.kde.org/r/118256/#comment40558>

    this red square shows extra whitespace at the end of the line.
    
    This is bad as it screws up our diffs in future. You can set Kate/KDevelop up to trim these under
    settings -> open/save



src/call-window.cpp
<https://git.reviewboard.kde.org/r/118256/#comment40559>

    We have a coding style here:
    http://techbase.kde.org/Policies/Kdelibs_Coding_Style
    
    it's
    
    if () {
    
    } else {
    
    }


- David Edmundson


On May 22, 2014, 12:51 p.m., Ekaitz Zárraga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118256/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 12:51 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> Implement showMyVideo.
> 
> 
> Diffs
> -----
> 
>   src/call-window.h f3a1ea3 
>   src/call-window.cpp 4f0e75d 
> 
> Diff: https://git.reviewboard.kde.org/r/118256/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ekaitz Zárraga
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140522/187b3f4c/attachment.html>