Review Request 118223: Add KTp::Actions::openLogViewer(Account account, QString target) overload

David Edmundson david at davidedmundson.co.uk
Tue May 20 14:09:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118223/#review58197
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On May 20, 2014, 1:55 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118223/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 1:55 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Current API only allows opening logviewer for a contact, or a KPeople person (via URI), but not for a channel, where we only have a string handle.
> 
> 
> Diffs
> -----
> 
>   KTp/actions.h 85d43dc 
>   KTp/actions.cpp c4c6f85 
> 
> Diff: https://git.reviewboard.kde.org/r/118223/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140520/761d1373/attachment.html>


More information about the KDE-Telepathy mailing list