Review Request 116940: State-affinity and engaging now Playing from a custom status message fixes.

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116940/
-----------------------------------------------------------

(Updated May 14, 2014, 11:56 p.m.)


Review request for Telepathy.


Changes
-------

Shorter comment in onPresenceChanged() and don't compare presence to last user presence before modifying plug-in enabled state. Thanks to commit e8d2621bbcfbb9288b53e66747d9dd7e399427bf, the issue causing bug 334492 and also related to this intended fix for sporadic Now Playing plug-in dropouts, has been identified and should be properly fixed. This restores status message plug-in behavior where non-displayed plug-ins are disabled on a presence or status message change.


Bugs: 332082, 334492 and 334542
    http://bugs.kde.org/show_bug.cgi?id=332082
    http://bugs.kde.org/show_bug.cgi?id=334492
    http://bugs.kde.org/show_bug.cgi?id=334542


Repository: ktp-kded-module


Description
-------

This patch returns the ability to engage status message plug-ins from custom status messages. Also working is the disabling of non-visible status message plug-ins. State-affinity in the 95% of previously noted cases has been vastly improved also, the few remaining issues should be due to "lite" protocols that don't have a full complement of on-line presences.


Diffs (updated)
-----

  status-handler.h 06240ff 
  status-handler.cpp 4b9c25a 
  telepathy-kded-module-plugin.h 4c16169 
  telepathy-kded-module-plugin.cpp daf73c6 
  telepathy-mpris.cpp 69e8562 

Diff: https://git.reviewboard.kde.org/r/116940/diff/


Testing
-------

Disconnect / reconnect, autoconnect / no autoconnect, suspend / resume. Enable / disable via kcm module. Added a new custom presence and engaged the now playing plugin in the contact list from the new presence. Disabled the plugin by activating another presence.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140514/d55e5cad/attachment.html>