Review Request 118066: Don't emit activateChanged signal if it hasn't changed

[David Edmundson]

> On May 10, 2014, 11:29 a.m., James Smith wrote:
> > This looks like a better way to prevent ticking plug-ins than the check in onPluginActivated(). This should also be applied to #116940 setMessagePluginActive() also, where it can work for the status plugins. Otherwise, the presence plugins usually only setActive() once on, and once off.
> 
> James Smith wrote:
>     At second glance, this code doesn't properly allow track changes with the mpris2 plugin.
> 
> David Edmundson wrote:
>     We have separate signals for
>     
>     Q_SIGNALS:
>         void requestPresenceChange(const Tp::Presence &presence);
>         void requestStatusMessageChange(const QString statusMessage);
>     
>

Oh.. they're not used.
brilliant.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118066/#review57670
-----------------------------------------------------------


On May 9, 2014, 11:53 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118066/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 11:53 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Don't emit activateChanged signal if it hasn't changed
> 
> 
> Diffs
> -----
> 
>   telepathy-kded-module-plugin.cpp daf73c6 
> 
> Diff: https://git.reviewboard.kde.org/r/118066/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140510/b371fd17/attachment.html>