Review Request 116940: State-affinity and engaging now Playing from a custom status message fixes.

[David Edmundson]

> On May 8, 2014, 9:01 p.m., David Edmundson wrote:
> > status-handler.cpp, line 215
> > <https://git.reviewboard.kde.org/r/116940/diff/11/?file=271992#file271992line215>
> >
> >     
> >     If we have:
> >     Now playing 
> >     
> >     Then AutoAway starts
> >     
> >     Then AutoAway ends
> >     
> >     we're no longer in now playing.
> 
> James Smith wrote:
>     No. With an empty AutoAway message the now playing plugin still functions. And returns when AutoAway is disabled.

Right, but if you had an auto away with a message, this would disable the now playing, no?


> On May 8, 2014, 9:01 p.m., David Edmundson wrote:
> > telepathy-mpris.cpp, line 281
> > <https://git.reviewboard.kde.org/r/116940/diff/11/?file=271995#file271995line281>
> >
> >     Surely, this wouldn't be needed if you hadn't changed line 274
> >     
> >     Changing it clearly complicates things
> 
> James Smith wrote:
>     It's a required change to allow the contact list to gracefully transition to the next presence post-active status message plugin. Otherwise the selected presence is ignored and the presence becomes what was used to set the status plugin active. This change makes certain that the kcm also still functions to enable / disable the now playing plugin.

If we didn't change line 274 from 
setEnabled() to setPluginEnabled() 
then it would call setActive(false) for us?

With this patch it can be active even if it's disabled. Which must be wrong?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116940/#review57615
-----------------------------------------------------------


On May 9, 2014, 6:14 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116940/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 6:14 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 332082, 334492 and 334542
>     http://bugs.kde.org/show_bug.cgi?id=332082
>     http://bugs.kde.org/show_bug.cgi?id=334492
>     http://bugs.kde.org/show_bug.cgi?id=334542
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> This patch returns the ability to engage status message plug-ins from custom status messages. Also working is the disabling of non-visible status message plug-ins. State-affinity in the 95% of previously noted cases has been vastly improved also, the few remaining issues should be due to "lite" protocols that don't have a full complement of on-line presences.
> 
> 
> Diffs
> -----
> 
>   status-handler.h 06240ff 
>   status-handler.cpp 4b9c25a 
>   telepathy-kded-module-plugin.h 4c16169 
>   telepathy-kded-module-plugin.cpp daf73c6 
>   telepathy-mpris.cpp 69e8562 
> 
> Diff: https://git.reviewboard.kde.org/r/116940/diff/
> 
> 
> Testing
> -------
> 
> Disconnect / reconnect, autoconnect / no autoconnect, suspend / resume. Enable / disable via kcm module. Added a new custom presence and engaged the now playing plugin in the contact list from the new presence. Disabled the plugin by activating another presence.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140510/7b0b926a/attachment-0001.html>