Review Request 116940: State-affinity and engaging now Playing from a custom status message fixes.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116940/#review57536
-----------------------------------------------------------



status-handler.cpp
<https://git.reviewboard.kde.org/r/116940/#comment40039>

    if nothing is active, you disable everything.
    
    What will that accomplish?



telepathy-kded-module-plugin.cpp
<https://git.reviewboard.kde.org/r/116940/#comment40037>

    We do not need
    
    setEnabled
    setActive
    
    AND
    
    setPluginEnabled
    
    The only difference between this and setenabled is that it doesn't emit a signal.
    Except you only call it when its inactive so that won't matter anyway.


- David Edmundson


On May 7, 2014, 10:25 p.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116940/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 10:25 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 332082
>     http://bugs.kde.org/show_bug.cgi?id=332082
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> This patch returns the ability to engage status message plug-ins from custom status messages. Also working is the disabling of non-visible status message plug-ins. State-affinity in the 95% of previously noted cases has been vastly improved also, the few remaining issues should be due to "lite" protocols that don't have a full complement of on-line presences. Custom presence comparisons have been optimized with presences being loaded only when required. This keeps disk access to a minimum without unnecessary reads and subsequent aborts before save due to filtering of the presence.
> 
> 
> Diffs
> -----
> 
>   status-handler.h 06240ff 
>   status-handler.cpp 4b9c25a 
>   telepathy-kded-module-plugin.h 4c16169 
>   telepathy-kded-module-plugin.cpp daf73c6 
>   telepathy-mpris.cpp 69e8562 
> 
> Diff: https://git.reviewboard.kde.org/r/116940/diff/
> 
> 
> Testing
> -------
> 
> Disconnect / reconnect, autoconnect / no autoconnect, suspend / resume. Enable / disable via kcm module. Added a new custom presence and engaged the now playing plugin in the contact list from the new presence. Disabled the plugin by activating another presence.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140507/23e53e1a/attachment.html>