Review Request 117991: Search-while-typing as requested in bug 318591

[Martin Klapetek]

> On May 4, 2014, 10:03 p.m., Martin Klapetek wrote:
> > Thanks for the patch; it's a good start but however not very good approach, we use a filter proxy model which can do the filtering for us, so the string should just be passed there.
> > 
> > In any case, see https://git.reviewboard.kde.org/r/117916/ where someone actually has done this already.
> > 
> > It also helps if you talk to us first about your plans before actual coding, we hate seeing code being thrown away because it was already done...sorry :)
> >
> 
> Martin Klapetek wrote:
>     ...and apparently we should talk among ourselves too before commenting on reviews :D
> 
> Olaf Piesche wrote:
>     No worries, I did it primarily as an exercise anyway ;)   The other patch does exactly what I couldn't get to work (match through the filter proxy model).  Kill this one, please :)

Just click discard in the right up corner :)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117991/#review57264
-----------------------------------------------------------


On May 4, 2014, 9:56 p.m., Olaf Piesche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117991/
> -----------------------------------------------------------
> 
> (Updated May 4, 2014, 9:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> When typing with the contact list widget in focus, finds the first matching contact to the string entered and selects it. If more than 1s passes between keyboard events, the search string is cleared. The only way I could figure out how to do this is to iterate over the contactsModel and match and select manually.
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h 8f39b81 
>   contact-list-widget.cpp 3ffa1cc 
> 
> Diff: https://git.reviewboard.kde.org/r/117991/diff/
> 
> 
> Testing
> -------
> 
> Typing with the contact list focused to find contacts. Tried other keyboard shortcuts, which still work. 
> 
> 
> Thanks,
> 
> Olaf Piesche
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140504/bf64f4ac/attachment.html>