Review Request 117968: Map connection presence type to string

[David Edmundson]

> On May 3, 2014, 5:46 p.m., Alexandr Akulich wrote:
> > kpeople/datasourceplugin/im-persons-data-source.cpp, line 75
> > <https://git.reviewboard.kde.org/r/117968/diff/1/?file=271238#file271238line75>
> >
> >     What is KABC standing for? It is a different product, isn't it?

KDE Address Book Component.

It's the namespace for Addressee which is the main class we use for storing contact data.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117968/#review57212
-----------------------------------------------------------


On May 2, 2014, 11:59 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117968/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 11:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Two commits:
> ----
> 
> Share the same QString for all KABC Custom fields
> 
> We should have a theoretically smaller memory footprint.
> 
> ----
> 
> 
> Map connection presence type to string
> 
> In libkpeople we pass the presence around as a string as that's all
> KABC::custom() supports.
> 
> We used to use presence->status(); this is problematic as it is free
> text which can contain anything; especially when on multiple protocols.
> 
> A presence might have the status "chat" which is mapped to the presence
> type Tp::ConnectionPresenceTypeOnline. We want to use this mapping and
> only have a subset of presence strings.
> 
> BUG: 334207
> 
> 
> Diffs
> -----
> 
>   kpeople/datasourceplugin/im-persons-data-source.cpp 44e2d5c 
> 
> Diff: https://git.reviewboard.kde.org/r/117968/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140503/4eef8f0f/attachment.html>