Review Request 117977: Fix for bug 333604 - icons in the presence chooser tooltip don't scale

[Ahmed I. Khalil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117977/#review57214
-----------------------------------------------------------



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/117977/#comment39876>

    Trailing white space. Please remove.



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/117977/#comment39877>

    Another trailing white space.



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/117977/#comment39878>

    Aren't the width and height attributes, should be surrounded with double quotes ? 
    Example: <img src="%1" width=\"22\" height=\"22\"/>
    
    Also please provide a screenshot for the changes, to help me to make sure that things are working.
    


- Ahmed I. Khalil


On May 3, 2014, 7:49 p.m., Olaf Piesche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117977/
> -----------------------------------------------------------
> 
> (Updated May 3, 2014, 7:49 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 333604
>     http://bugs.kde.org/show_bug.cgi?id=333604
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Scaling icons in the presence chooser tool tip. The tooltip contains HTML, and the icons for accounts weren't scaled at all.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 9eded30 
> 
> Diff: https://git.reviewboard.kde.org/r/117977/diff/
> 
> 
> Testing
> -------
> 
> Ran locally. Hovered until tooltip opened.
> 
> 
> Thanks,
> 
> Olaf Piesche
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140503/1224b226/attachment-0001.html>