Review Request 116940: State-affinity and engaging now Playing from a custom status message fixes.

[David Edmundson]

> On March 31, 2014, 2:18 p.m., James Smith wrote:
> > telepathy-module.cpp, line 176
> > <https://git.reviewboard.kde.org/r/116940/diff/4/?file=258119#file258119line176>
> >
> >     This segment by default allows nowPlaying messages to overwrite custom status messages. This behaviour causes a small problem where if a custom message is activated during a track with nowPlaying enabled, on the next track change the custom message is overwritten with the track information. The default behaviour is required to allow the contact list to engage nowPlaying from a custom status message to begin with. The nowPlaying engagement issue doesn't exist when the custom presence message has to be empty to change to the nowPlaying track information, making any custom presence message preferred over custom presence message plugin output.

> This behaviour causes a small problem where if a custom message is activated during a track with nowPlaying enabled, on the next track change the custom message is overwritten with the track.

Doesn't setting a custom message deactivate now playing?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116940/#review54676
-----------------------------------------------------------


On March 30, 2014, 3:15 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116940/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 3:15 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 332082
>     http://bugs.kde.org/show_bug.cgi?id=332082
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Fixes engage-nowPlaying-from-custom-status-message and lessens disk activity on presence change. Also simplifies logic used to keep telepathy-kded-module in a "fit" state during run-time.
> 
> 
> Diffs
> -----
> 
>   telepathy-module.cpp 030a0d9 
>   telepathy-module.h 2213cdf 
> 
> Diff: https://git.reviewboard.kde.org/r/116940/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140331/3d0b3fb0/attachment-0001.html>