Review Request 117181: Use SettingsKcmDialog from K-C-I

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117181/#review54629
-----------------------------------------------------------



presence/src/presence-applet.cpp
<https://git.reviewboard.kde.org/r/117181/#comment38193>

    Same as the other thread.
    
    When you fix that. Ship it here too



presence/src/presence-applet.cpp
<https://git.reviewboard.kde.org/r/117181/#comment38194>

    I would recommend
    
    show() over exec() here.
    
    With exec you would lock up all of the plasma shell. Which is generally a naughty thing to do.
    


- David Edmundson


On March 30, 2014, 8:05 a.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117181/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 8:05 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 326998
>     http://bugs.kde.org/show_bug.cgi?id=326998
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Ported from ktp-contact-list's contact-list-widget.cpp
> 
> 
> Diffs
> -----
> 
>   presence/src/presence-applet.h e090f795222a582aa68203b9a5bd8e94fc968963 
>   presence/src/presence-applet.cpp 188707068114ba5b8d97aec5d8f38fff573afb01 
> 
> Diff: https://git.reviewboard.kde.org/r/117181/diff/
> 
> 
> Testing
> -------
> 
> Settings dialog successfully opens
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140330/9d89e180/attachment.html>