Review Request 117179: Add SettingsKCMDialog to open KTp Settings

[Martin Klapetek]

> On March 30, 2014, 4:28 p.m., Siddhartha Sahu wrote:
> > KTp/Widgets/settings-kcm-dialog.cpp, line 37
> > <https://git.reviewboard.kde.org/r/117179/diff/3/?file=258234#file258234line37>
> >
> >     Is this the correct parent for this widget?

Yes.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117179/#review54604
-----------------------------------------------------------


On March 30, 2014, 4:27 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117179/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 4:27 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Ported from ktp-contact-list's contact-list-widget.cpp
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/CMakeLists.txt f6b817616873c340aa5791e405f1a502c9f0f5c2 
>   KTp/Widgets/settings-kcm-dialog.h PRE-CREATION 
>   KTp/Widgets/settings-kcm-dialog.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117179/diff/
> 
> 
> Testing
> -------
> 
> Settings dialog opens from both contact-list and desktop-applet
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140330/dd3c4ba9/attachment.html>