Review Request 117179: Add SettingsKCMDialog to open KTp Settings

Thomas Pfeiffer colomar at autistici.org
Sun Mar 30 12:40:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117179/#review54596
-----------------------------------------------------------


In case it's not already done with this patch: The "Account Manager" action can be removed now that we have the settings action, because the KCM includes Accounts.
And thanks for implementing this, I've been bugging David about this for a loooong time :)

- Thomas Pfeiffer


On March 30, 2014, 8:05 a.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117179/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 8:05 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Ported from ktp-contact-list's contact-list-widget.cpp
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/settings-kcm-dialog.cpp PRE-CREATION 
>   KTp/Widgets/settings-kcm-dialog.h PRE-CREATION 
>   KTp/Widgets/CMakeLists.txt f6b817616873c340aa5791e405f1a502c9f0f5c2 
> 
> Diff: https://git.reviewboard.kde.org/r/117179/diff/
> 
> 
> Testing
> -------
> 
> Settings dialog opens from both contact-list and desktop-applet
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140330/e04ef1a7/attachment.html>


More information about the KDE-Telepathy mailing list