Review Request 117172: Catch errors in PersonManager

Martin Klapetek martin.klapetek at gmail.com
Sun Mar 30 00:12:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117172/#review54572
-----------------------------------------------------------

Ship it!



src/personmanager.cpp
<https://git.reviewboard.kde.org/r/117172/#comment38168>

    ;; -> ;



src/personmanager.cpp
<https://git.reviewboard.kde.org/r/117172/#comment38169>

    if( -> if (


- Martin Klapetek


On March 30, 2014, 1:07 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117172/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 1:07 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Catch errors in PersonManager
> 
> If a database commit fails roll back changes and don't emit signals to
> other clients
> 
> 
> Diffs
> -----
> 
>   src/personmanager.cpp f71e70d 
> 
> Diff: https://git.reviewboard.kde.org/r/117172/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140330/fe11dd4e/attachment.html>


More information about the KDE-Telepathy mailing list