Review Request 116880: Add PresenceManager class for use from QML

[Martin Klapetek]

> On March 29, 2014, 6:02 p.m., Martin Klapetek wrote:
> > KTp/Declarative/presence-manager.h, lines 44-54
> > <https://git.reviewboard.kde.org/r/116880/diff/2/?file=258059#file258059line44>
> >
> >     Is there a reason we copy this from tp-qt? Can we just do Q_ENUMS(Tp::ConnectionPresenceType) (if it's not already)?
> 
> Siddhartha Sahu wrote:
>     I did try. I'm getting an "error: ‘staticMetaObject’ is not a member of ‘Tp’"

Oh right, you actually need this here (you can expose Q_ENUMS only from the class that you're exposing). However we should map it to the Tp values, so change it to

Offline = Tp::ConnectionPresenceTypeOffline,
Online = Tp::ConnectionPresenceTypeOnline,

etc


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116880/#review54558
-----------------------------------------------------------


On March 29, 2014, 5:30 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116880/
> -----------------------------------------------------------
> 
> (Updated March 29, 2014, 5:30 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> [Work in progress]
> 
> This adds a PresenceManager class to Declarative code that can be used from QML to get and set global presence.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/qml-plugins.cpp bc134e0dcb35ebd323dee5164a8ce5ae5537dd75 
>   KTp/Declarative/presence-manager.cpp PRE-CREATION 
>   KTp/Declarative/presence-manager.h PRE-CREATION 
>   KTp/Declarative/CMakeLists.txt 57025536af43279d31380f32a2827e4060686fdc 
> 
> Diff: https://git.reviewboard.kde.org/r/116880/diff/
> 
> 
> Testing
> -------
> 
> Is accessible from ktp-active, functions called successfully with parameters
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140330/7d962228/attachment.html>