Review Request 117141: Handle Akonadi::Job errors in AllContactsMonitor
David Edmundson
david at davidedmundson.co.uk
Fri Mar 28 22:57:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117141/#review54514
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On March 28, 2014, 5:41 p.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117141/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 5:41 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: libkpeople
>
>
> Description
> -------
>
> This patch will check for errors from Akonadi jobs and adds bool argument to emitInitialFetchComplete() method to say whether the initial fetch was successful, or a Job failed.
>
>
> Diffs
> -----
>
> src/allcontactsmonitor.h 1ad2860
> src/allcontactsmonitor.cpp 4c2c3d2
> src/personsmodel.h c6ab4c6
> src/personsmodel.cpp 050cf7b
> src/plugins/akonadi/akonadidatasource.cpp 2f006c9
>
> Diff: https://git.reviewboard.kde.org/r/117141/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Vrátil
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140328/fbf36dee/attachment.html>
More information about the KDE-Telepathy
mailing list