Review Request 117138: Added presence request message in the add contact dialog

[Thomas Pfeiffer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117138/#review54513
-----------------------------------------------------------


The HIG indeed doesn't say anything about labels for optional fields (maybe we should add something if it's needed by others as well).
I'd make the box two lines high because a message text may easily get longer than just the few characters that currently fit in there. Then you can change the label to "Message (optional)" with a line break and remove the text below.


- Thomas Pfeiffer


On March 28, 2014, 10:24 p.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117138/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 10:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 318529
>     http://bugs.kde.org/show_bug.cgi?id=318529
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Added an optional text input line for the capability of sending a message with presence requests.
> 
> I'm not entirely sure of the HIG for making it clear that it's an optional field, so put the label below for now - putting 'message (optional)' on the left-hand label looks unreasonably awkward to me.
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/add-contact-dialog.h 2004a27 
>   KTp/Widgets/add-contact-dialog.cpp 045c0e3 
>   KTp/Widgets/add-contact-dialog.ui fc355ff 
> 
> Diff: https://git.reviewboard.kde.org/r/117138/diff/
> 
> 
> Testing
> -------
> 
> I sent several presence requests, the message received successfully each time.
> 
> 
> File Attachments
> ----------------
> 
> add contact dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/28/0c482442-8a19-4c15-9ae3-ff0bbffb933c__message.png
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140328/97e83fee/attachment.html>