Review Request 117138: Added presence request message in the add contact dialog

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117138/#review54511
-----------------------------------------------------------


Minor nitpicks.

Thomas: Can you review the screenshot please.


KTp/Widgets/add-contact-dialog.h
<https://git.reviewboard.kde.org/r/117138/#comment38132>

    I like private slots being named:
    
    onSomeEventHappened()
    
    or public slots being named:
     - whatIActuallyDo()
    
    
    
    so either
    onAccountIndexChanged
    or
    updateSubscriptionMessageVisibility()



KTp/Widgets/add-contact-dialog.cpp
<https://git.reviewboard.kde.org/r/117138/#comment38131>

    Nitpick, watch your whitespace
    
    if (foo) {
    
    }
    
    
    (space before { )
    
    
    it's also 
    } else {
    
    See http://techbase.kde.org/Policies/Kdelibs_Coding_Style



KTp/Widgets/add-contact-dialog.cpp
<https://git.reviewboard.kde.org/r/117138/#comment38130>

    give these proper names.
    


- David Edmundson


On March 28, 2014, 10:24 p.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117138/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 10:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 318529
>     http://bugs.kde.org/show_bug.cgi?id=318529
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Added an optional text input line for the capability of sending a message with presence requests.
> 
> I'm not entirely sure of the HIG for making it clear that it's an optional field, so put the label below for now - putting 'message (optional)' on the left-hand label looks unreasonably awkward to me.
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/add-contact-dialog.h 2004a27 
>   KTp/Widgets/add-contact-dialog.cpp 045c0e3 
>   KTp/Widgets/add-contact-dialog.ui fc355ff 
> 
> Diff: https://git.reviewboard.kde.org/r/117138/diff/
> 
> 
> Testing
> -------
> 
> I sent several presence requests, the message received successfully each time.
> 
> 
> File Attachments
> ----------------
> 
> add contact dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/28/0c482442-8a19-4c15-9ae3-ff0bbffb933c__message.png
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140328/191b5397/attachment-0001.html>