Review Request 117142: Add "bool success" argument to ContactsListModel::modelInitialized() signal

David Edmundson david at davidedmundson.co.uk
Fri Mar 28 17:53:35 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117142/#review54478
-----------------------------------------------------------

Ship it!



KTp/Models/contacts-list-model.cpp
<https://git.reviewboard.kde.org/r/117142/#comment38121>

    We can remove this if statement I think.


- David Edmundson


On March 28, 2014, 5:44 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117142/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 5:44 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> This patch makes sure that the success state from KPeople gets propagated up to KTp::ContactsListModel and makes K-C-I compile with the API changes done in review 117141.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/contacts-list-model.h dc3e63f 
>   KTp/Models/contacts-list-model.cpp d5d01c2 
>   KTp/Models/contacts-model.h e6fb7b1 
>   KTp/Models/contacts-model.cpp df1d487 
>   kpeople/datasourceplugin/im-persons-data-source.cpp 94d8de1 
> 
> Diff: https://git.reviewboard.kde.org/r/117142/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140328/c5398738/attachment.html>


More information about the KDE-Telepathy mailing list