Review Request 117138: Added presence request message in the add contact dialog

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117138/#review54475
-----------------------------------------------------------


Please check 
bool Tp::ContactManager::subscriptionRequestHasMessage() const

and hide the new line edit if this is false
http://telepathy.freedesktop.org/doc/telepathy-qt/a00201.html#abd8e2c4544a1724e5fb10bf16c80b001

- David Edmundson


On March 28, 2014, 5:29 p.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117138/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 5:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 318529
>     http://bugs.kde.org/show_bug.cgi?id=318529
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Added an optional text input line for the capability of sending a message with presence requests.
> 
> I'm not entirely sure of the HIG for making it clear that it's an optional field, so put the label below for now - putting 'message (optional)' on the left-hand label looks unreasonably awkward to me.
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/add-contact-dialog.cpp 045c0e3 
>   KTp/Widgets/add-contact-dialog.ui fc355ff 
> 
> Diff: https://git.reviewboard.kde.org/r/117138/diff/
> 
> 
> Testing
> -------
> 
> I sent several presence requests, the message received successfully each time.
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140328/6cfae9d5/attachment.html>