Review Request 117138: Added presence request message in the add contact dialog
Daniel Cohen
analoguecolour at gmail.com
Fri Mar 28 17:29:27 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117138/
-----------------------------------------------------------
Review request for Telepathy.
Bugs: 318529
http://bugs.kde.org/show_bug.cgi?id=318529
Repository: ktp-common-internals
Description
-------
Added an optional text input line for the capability of sending a message with presence requests.
I'm not entirely sure of the HIG for making it clear that it's an optional field, so put the label below for now - putting 'message (optional)' on the left-hand label looks unreasonably awkward to me.
Diffs
-----
KTp/Widgets/add-contact-dialog.cpp 045c0e3
KTp/Widgets/add-contact-dialog.ui fc355ff
Diff: https://git.reviewboard.kde.org/r/117138/diff/
Testing
-------
I sent several presence requests, the message received successfully each time.
Thanks,
Daniel Cohen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140328/3ed789b1/attachment.html>
More information about the KDE-Telepathy
mailing list