Review Request 116774: Integration with keyboard layout switcher, allow separate keyboard layout per chat tab.

Commit Hook null at kde.org
Tue Mar 25 10:49:05 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116774/#review54092
-----------------------------------------------------------


This review has been submitted with commit 7599bc88d73901e4a8eb05fee0791a604d8a1e08 by David Edmundson on behalf of Ahmed Ibrahim to branch master.

- Commit Hook


On March 24, 2014, 10:15 p.m., Ahmed Ibrahim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116774/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 10:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 308953
>     http://bugs.kde.org/show_bug.cgi?id=308953
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Used DBus interface to switch the keyboard layout and listen to the keyboard layout change. Stored the language in each ChatTab instance and then restore it back when the ChatWindow is activated and when switching between tabs.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 793ac55 
>   app/chat-window.cpp 2c2e12b 
>   lib/chat-widget.h c1dbd41 
>   lib/chat-widget.cpp e7c7619 
> 
> Diff: https://git.reviewboard.kde.org/r/116774/diff/
> 
> 
> Testing
> -------
> 
> Opened multiple ChatTabs and changed language of each one of them. When Switching between the tabs the language indicator is changed according to the language that is stored in the ChatTab.
> 
> 
> Thanks,
> 
> Ahmed Ibrahim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140325/b233a4e5/attachment.html>


More information about the KDE-Telepathy mailing list