Review Request 114660: Ktp Config Connection State pane

Thomas Pfeiffer colomar at autistici.org
Tue Mar 25 08:40:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114660/#review54069
-----------------------------------------------------------


Looks good to me from the usability perspective now!

- Thomas Pfeiffer


On March 25, 2014, 2:28 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114660/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 2:28 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Moves 3 connection state configurations into a single group box saving space.
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.ui 18f06f3 
>   config/telepathy-kded-config.cpp baaceff 
> 
> Diff: https://git.reviewboard.kde.org/r/114660/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> File Attachments
> ----------------
> 
> Conection state selectors in a frame
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/25/2b5322ec-ea0b-4e16-86dc-e0ef7bb4691b__connectionstateswithkeepawake.png
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140325/bd68f493/attachment.html>


More information about the KDE-Telepathy mailing list