Review Request 116774: Integration with keyboard layout switcher, allow separate keyboard layout per chat tab.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116774/#review52877
-----------------------------------------------------------

Ship it!


Sorry for the delay. I was on vacation.

Long term I think I want a visual cue inside the chat tab. Otherwise the behaviour might just seem erratic, also I'd like to have save/restore per contact when starting a chat with a known contact. 

The code itself seems pretty rock solid. Thanks.


lib/chat-widget.cpp
<https://git.reviewboard.kde.org/r/116774/#comment37226>

    pedantic comment 
    
    QString &language 
    
    not 
    
    QString& language


Do you have commit access?

- David Edmundson


On March 12, 2014, 11:04 p.m., Ahmed Ibrahim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116774/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 11:04 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 308953
>     http://bugs.kde.org/show_bug.cgi?id=308953
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Used DBus interface to switch the keyboard layout and listen to the keyboard layout change. Stored the language in each ChatTab instance and then restore it back when the ChatWindow is activated and when switching between tabs.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 793ac55 
>   app/chat-window.cpp 2c2e12b 
>   lib/chat-widget.h c1dbd41 
>   lib/chat-widget.cpp e7c7619 
> 
> Diff: https://git.reviewboard.kde.org/r/116774/diff/
> 
> 
> Testing
> -------
> 
> Opened multiple ChatTabs and changed language of each one of them. When Switching between the tabs the language indicator is changed according to the language that is stored in the ChatTab.
> 
> 
> Thanks,
> 
> Ahmed Ibrahim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140324/8503ebdd/attachment-0001.html>